reviewdog / action-reek

Run reek with reviewdog 🐶
MIT License
10 stars 6 forks source link

is not running against files properly #1

Closed al3rez closed 4 years ago

al3rez commented 4 years ago

reek doesn't run against files in github actions while in local machine it returns the errors.

reek --single-line | reviewdog -f=reek -diff="git diff develop"
mgrachev commented 4 years ago

Yes, you are right. I started this action, but have not finished yet 😞

It would be great if you help me with this problem and we would finish this action together. What do you think?

al3rez commented 4 years ago

I've fixed just now, it seems reek pipeline doesn't work like the other tools, I've provided file paths and it worked

  reek:
    name: runner / reek
    runs-on: ubuntu-latest
    steps:
      - name: Check out code
        uses: actions/checkout@v1
      - name: reek
        uses: mgrachev/action-reek@v0.1.6
        with:
          github_token: ${{ secrets.github_token }}
          reek_flags: app/**/*.rb
          reporter: github-pr-review # Default is github-pr-check

I guess you have to always provide path because I've tried many and the only way is to provide the path.

mgrachev commented 4 years ago

@alirezabashyri Thank you for your help!

mgrachev commented 4 years ago

@alirezabashyri Now it works! 🎉