search

reviewdog / action-remark-lint

Run remark-lint with Reviewdog :dog:
https://github.com/reviewdog/reviewdog
MIT License
5 stars 9 forks source link

Rename `master` to `main` #48

Closed asbjornu closed 2 years ago

asbjornu commented 3 years ago

For consistency with the rest of the community and to avoid the negative baggage associated with master, I suggest we rename master to main. Before this can happen, master needs to be replaced with main in the following places:

https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/.github/workflows/depup.yml#L32

https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/.github/workflows/dockerimage.yml#L5

https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/.github/workflows/release.yml#L5

https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/.github/workflows/reviewdog.yml#L5

https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/.github/workflows/test.yml#L5

rickstaa commented 3 years ago

@asbjornu Looks good to me, since GitHub internally now also uses main as the default branch (see https://github.com/github/renaming). I know this is a sensitive topic and understand that some people might disagree with GitHub's decision, but I see no harm in merging #49 under v4.

I will hold off merging #49 till 13-09-2021 since there are a lot of downvotes on this issue. If somebody has a good argument, why #49 should not be merged, feel free to comment on this topic.

rickstaa commented 3 years ago

This issue will be closed by #53 and #52. Before these can be merged, the default branch has to be changed.

rickstaa commented 2 years ago

This was implemented in https://github.com/reviewdog/action-remark-lint/releases/tag/v4.0.0.