reviewdog / action-remark-lint

Run remark-lint with Reviewdog :dog:
https://github.com/reviewdog/reviewdog
MIT License
5 stars 9 forks source link

Make `github_token` optional #61

Closed asbjornu closed 2 years ago

asbjornu commented 2 years ago

Make github_token optional. Resolves #60.

rickstaa commented 2 years ago

@asbjornu Thanks for spotting this. Feel free to merge it under the major, minor or patch labels.

rickstaa commented 2 years ago

I prefer the bump:minor label since it is a significant change but does not break things.

asbjornu commented 2 years ago

I prefer the bump:minor label since it is a significant change but does not break things.

I agree, but I'm not certain I understand what you mean by "label". As in conventional commits or by manually creating a v5.1.0 tag in Git?

rickstaa commented 2 years ago

Ah sorry for being so unclear, it was related to the git label used by the release action. This will create the tag automatically when the pull request is merged.

github-actions[bot] commented 2 years ago

🚀 [bumpr] Bumped! New version:v5.1.0 Changes:v5.0.2...v5.1.0

rickstaa commented 2 years ago

Released under https://github.com/reviewdog/action-remark-lint/releases/tag/v5.1.0

asbjornu commented 2 years ago

Ah, right. Thanks, @rickstaa! 🙏🏼