search

reviewdog / action-rubocop

Run rubocop with reviewdog 🐶
MIT License
114 stars 75 forks source link

Put `${INPUT_RUBOCOP_FLAGS}` at the end of the other flags #120

Closed moznion closed 1 month ago

moznion commented 1 month ago

Since PR #103 introduced the default --fail-level flag, the severity level has become unchangeable due to this modification. Ideally, this flag (and others) should be overridable, but the RuboCop command prioritizes the flags that are specified last. This commit moves the user-specified flags to the end of the hard-coded flags, allowing them to be overridden.

rel: https://github.com/reviewdog/action-rubocop/pull/103/files#r1724248253

ohbarye commented 1 month ago

@moznion Thank you for your contribution.

As stated in https://github.com/reviewdog/action-rubocop/pull/103/files#r1724248253, I wonder if the added --fail-level error is intentional. Anyway, I believe INPUT_RUBOCOP_FLAGS should be prioritized so I'm merging this one.

github-actions[bot] commented 1 month ago

🚀 [bumpr] Bumped! New version:v2.18.1 Changes:v2.18.0...v2.18.1

review-dog commented 1 month ago

Hi, @moznion! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!