search

reviewdog / action-rubocop

Run rubocop with reviewdog 🐶
MIT License
115 stars 75 forks source link

Support offenses with no location #123

Closed pcallewaert closed 1 month ago

pcallewaert commented 1 month ago

We noticed 2 rubocop offenses were ignored by reviewdog in our code:

These were skipped because they have no location. This meant our pull requests were green but we had some rubocop offenses if we did a full scan on the main branch.

This PR changes the behaviour by not skipping the whole offense, but only the range data.

image
pcallewaert commented 1 month ago

The test should be fixed now :)

review-dog commented 1 month ago

Hi, @pcallewaert! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

github-actions[bot] commented 1 month ago

🚀 [bumpr] Bumped! New version:v2.19.1 Changes:v2.19.0...v2.19.1