Closed ybiquitous closed 3 years ago
@ybiquitous Hi 👋
Sorry for the long answer and thank you for your offer. I like it 🙂
@mgrachev Thank you so much! 🎉
In addition, it would be very nice if other reviewdog actions could support the optional github_token
parameter as well. 😄
Good idea! Thanks!
Oh, super fast! Thank you! ⚡ 😁
Hi there,
In this issue, I suggest making the
github_token
input parameter optional by setting the default token (secrets.GITHUB_TOKEN
orgithub.token
). The reason is that people can use this action with less configuration code.https://github.com/reviewdog/action-rubocop/blob/bc5455ef2cd8f9e77232dc19c79bc0e450df8ed3/action.yml#L5-L7
For example, the change would be like this:
See also: