search

reviewdog / action-rubocop

Run rubocop with reviewdog 🐶
MIT License
115 stars 75 forks source link

[BUG] Invalid request. Only 65535 characters are allowed; 70292 were supplied. #67

Closed Speak2Erase closed 9 months ago

Speak2Erase commented 2 years ago

Any action run I try fails with Invalid request. Only 65535 characters are allowed; 70292 were supplied. Configuration:

name: Rubocop
on: pull_request
jobs:
  rubocop:
    name: runner / rubocop
    runs-on: ubuntu-latest
    steps:
      - name: Check out code
        uses: actions/checkout@v1
      - uses: ruby/setup-ruby@v1
        with:
          ruby-version: 3.1.0
      - name: rubocop
        uses: reviewdog/action-rubocop@v2
        with:
          rubocop_version: gemfile
          rubocop_extensions: rubocop-rails:gemfile rubocop-rspec:gemfile
          reporter: github-pr-check # Default is github-pr-check
ohbarye commented 2 years ago

Hi! Could you provide a log to check the problem?

Speak2Erase commented 2 years ago

Sure, let me go fetch one.

Speak2Erase commented 2 years ago

Log archive

ohbarye commented 2 years ago

I'm convinced that the gist of the error is below. An HTTP request to post to GitHub by reviewdog has failed due to too big request content (reviewdog's code is here).

2022-02-28T02:09:15.2456076Z ##[group] Running rubocop with reviewdog 🐶 ...
2022-02-28T02:09:50.4823074Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor.rb: Warning: no department given for MethodLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:51.1862309Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/base.rb: Warning: no department given for AssignmentInCondition. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:51.5781666Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/group.rb: Warning: no department given for MethodLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:51.8641190Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/parser/arguments.rb: Warning: no department given for ClassLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:51.9426814Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/parser/option.rb: Warning: no department given for AssignmentInCondition. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.0372154Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/parser/options.rb: Warning: no department given for ClassLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.0384736Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/parser/options.rb: Warning: no department given for MethodLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.0385766Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/parser/options.rb: Warning: no department given for AssignmentInCondition. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.1328435Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/rake_compat.rb: Warning: no department given for AssignmentInCondition. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.1330828Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/rake_compat.rb: Warning: no department given for AssignmentInCondition. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.1973777Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/runner.rb: Warning: no department given for ClassLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.1994137Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/runner.rb: Warning: no department given for MethodLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:09:52.4341279Z /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/bundler/vendor/thor/lib/thor/shell/basic.rb: Warning: no department given for MethodLength. Run `rubocop -a --only Migration/DepartmentName` to fix.
2022-02-28T02:10:09.2058784Z An error occurred while Style/ParallelAssignment cop was inspecting /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/fiddle/import.rb:178:8.
2022-02-28T02:10:09.2059419Z To see the complete backtrace run rubocop -d.
2022-02-28T02:10:09.2060079Z An error occurred while Style/ParallelAssignment cop was inspecting /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/fiddle/import.rb:206:8.
2022-02-28T02:10:09.2060623Z To see the complete backtrace run rubocop -d.
2022-02-28T02:11:45.9205056Z 
2022-02-28T02:11:45.9205759Z 2 errors occurred:
2022-02-28T02:11:45.9206873Z An error occurred while Style/ParallelAssignment cop was inspecting /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/fiddle/import.rb:178:8.
2022-02-28T02:11:45.9207963Z An error occurred while Style/ParallelAssignment cop was inspecting /home/runner/work/OSFM-GitHub/OSFM-GitHub/lib/ruby/fiddle/import.rb:206:8.
2022-02-28T02:11:45.9208618Z Errors are usually caused by RuboCop bugs.
2022-02-28T02:11:45.9210047Z Please, report your problems to RuboCop's issue tracker.
2022-02-28T02:11:45.9273620Z https://github.com/rubocop/rubocop/issues
2022-02-28T02:11:45.9273831Z 
2022-02-28T02:11:45.9273968Z Mention the following information in the issue report:
2022-02-28T02:11:45.9274857Z 1.25.1 (using Parser 3.1.1.0, rubocop-ast 1.16.0, running on ruby 3.1.0 x86_64-linux)
2022-02-28T02:12:14.9723497Z {"severity":"ERROR","time":"2022-02-28T02:12:14.971888655Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Invalid request.\\n\\nOnly 65535 characters are allowed; 70292 were supplied.\",\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
2022-02-28T02:12:14.9725646Z {"severity":"DEBUG","time":"2022-02-28T02:12:14.972033357Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 1"}
2022-02-28T02:12:16.2216799Z {"severity":"ERROR","time":"2022-02-28T02:12:16.221290711Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Invalid request.\\n\\nOnly 65535 characters are allowed; 70292 were supplied.\",\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
2022-02-28T02:12:16.2218747Z {"severity":"DEBUG","time":"2022-02-28T02:12:16.221339711Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 2"}
2022-02-28T02:12:17.4815048Z {"severity":"ERROR","time":"2022-02-28T02:12:17.48104636Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Invalid request.\\n\\nOnly 65535 characters are allowed; 70292 were supplied.\",\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
2022-02-28T02:12:17.4816901Z {"severity":"DEBUG","time":"2022-02-28T02:12:17.48110226Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 3"}
2022-02-28T02:12:18.7889020Z {"severity":"ERROR","time":"2022-02-28T02:12:18.78839901Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Invalid request.\\n\\nOnly 65535 characters are allowed; 70292 were supplied.\",\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
2022-02-28T02:12:18.7890898Z {"severity":"DEBUG","time":"2022-02-28T02:12:18.78845331Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 4"}
2022-02-28T02:12:20.0172176Z {"severity":"ERROR","time":"2022-02-28T02:12:20.016740193Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Invalid request.\\n\\nOnly 65535 characters are allowed; 70292 were supplied.\",\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
2022-02-28T02:12:20.0174472Z {"severity":"DEBUG","time":"2022-02-28T02:12:20.016789793Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 5"}
2022-02-28T02:12:21.0172815Z reviewdog: post failed for rubocop: failed to post result: PATCH https://api.github.com/repos/Speak2Erase/OSFM-GitHub/check-runs/5353992812: 422 Invalid request.
2022-02-28T02:12:21.0189863Z 
2022-02-28T02:12:21.0190125Z Only 65535 characters are allowed; 70292 were supplied. []
2022-02-28T02:12:21.0227989Z ##[error]Process completed with exit code 1.

But I'm still not sure what makes such a big request body.

Speak2Erase commented 2 years ago

If I had to guess, I have an extremely large codebase of around ~100,000 lines of code that for the past few years has not been following the style guide very closely. Rubocop generates a lot of complaints, and so there's an extremely large request size?

javierjulio commented 9 months ago

This should be resolved by https://github.com/reviewdog/reviewdog/pull/1264 in a newer reviewdog release.