search

reviewdog / action-rubocop

Run rubocop with reviewdog 🐶
MIT License
114 stars 75 forks source link

Change `original_output` in `RdjsonFormatter`, adding file #80

Closed Slike9 closed 1 year ago

Slike9 commented 1 year ago

original_output field in RdjsonFormatter is printed by reviewdog on running the action with github-pr-review reporter.

Before, it did not contain file, thus messages were not fully informative. Example https://github.com/Slike9/GitHub-Actions-PlayGround/actions/runs/3887880250/jobs/6634622915#step:5:61

C:  1:  1: Style/FrozenStringLiteralComment: Missing frozen string literal comment.

This PR fixes the field, adding file. Example https://github.com/Slike9/GitHub-Actions-PlayGround/actions/runs/3887873154/jobs/6634608438#step:5:61

index.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment.

This format is borrowed from ClangStyleFormatter formatter (default formatter, ProgressFormatter, inherits it).

mgrachev commented 1 year ago

@Slike9 Thank you 👍

github-actions[bot] commented 1 year ago

🚀 [bumpr] Bumped! New version:v2.3.2 Changes:v2.3.1...v2.3.2

review-dog commented 1 year ago

Hi, @Slike9! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!