search

reviewdog / action-setup

:dog: Setup reviewdog action
MIT License
63 stars 22 forks source link

Action succeeds even if reviewdog was not installed #20

Closed carmanchris31 closed 1 year ago

carmanchris31 commented 1 year ago

Here is the output of a recent run of this action on :

Run actions/reviewdog-action-setup@v1
  with:
    reviewdog_version: latest
Run $GITHUB_ACTION_PATH/install.sh
  $GITHUB_ACTION_PATH/install.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    REVIEWDOG_VERSION: latest
    REVIEWDOG_TEMPDIR: /github/workspace/_temp
🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
  reviewdog/reviewdog info checking GitHub for tag 'latest'
  reviewdog/reviewdog info found version:  <!DOCTYPE html> <html lang= for  <!DOCTYPE html> <html lang=/Linux/x86_64
Run echo "::group::📖 reviewdog -h"
  echo "::group::📖 reviewdog -h"
  reviewdog -h [2](redacted)>&1 || true
  echo "::endgroup::"
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
📖 reviewdog -h
  /github/workspace/_temp/e7b059ba-ea0e-4b69-9afa-9[3](redacted)2fe773[6](redacted)06d.sh: line 2: reviewdog: command not found

Something bad happened that's causing reviewdog not to be installed, however the action still passes because of the || true here: https://github.com/reviewdog/action-setup/blob/a2416d57a2d4af8546c07bd56c561ec91481c7aa/action.yml#L17

This defeats the purpose of the self-check at the end.

austinpray-mixpanel commented 1 year ago

https://github.com/reviewdog/action-setup/pull/21 🤷