search

reviewdog / action-shellcheck

Run shellcheck with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
101 stars 20 forks source link

Scope clarification #20

Closed alan-barzilay closed 3 years ago

alan-barzilay commented 3 years ago

Hi! this may be a stupid question so I'm sorry in advance if this is not the place for it.

When reviewdog reviews a PR with shellcheck, does it look only at the changes made in the PR or does it look at everything in the repo?

I have a bash repo in which I want to use this action, but shellcheck has a lot of problems with it so checking the codebase with shellcheck right now is pretty much useless since every file will be flagged with something. I wanted to avoid introducing even more problems in the repo while I fix all shellcheck complaints, so I wanted to run shellcheck only on the things changed in the PR. Is this something possible to do with this action? Will this action only spot the new problems introduced in the PR or will it complain about everything that was already wrong even before the PR?

Thank you for your time and the amazing tool!

alan-barzilay commented 3 years ago

After reading the review dog documentation I realized the filter_mode: added does this, so I'm closing the issue