search

reviewdog / action-staticcheck

🐶 Run staticcheck with reviewdog on pull requests to improve code review experience.
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
18 stars 2 forks source link

Should this be failing if there is an issue in a filtered finding? #10

Closed tmc closed 3 years ago

tmc commented 3 years ago

I'm seeing this behavior:

Screen Shot 2020-11-09 at 3 49 44 PM

With this config:

  staticcheck:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: reviewdog/action-staticcheck@v1
        with:
          github_token: ${{ secrets.github_token }}
          reporter: github-check

Is it expected to fail a PR if there are no newly introduced lint issues?

tmc commented 3 years ago

Oddly, adding fail_on_error: false causes the pr check to still mark the PR red..

haya14busa commented 3 years ago

It's expected. Use filter_mode: nofilter if you want to check results outside diff.