search

reviewdog / action-stylelint

Run stylelint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
46 stars 24 forks source link

Fix formatters other than github-pr-review #86

Closed pixeldesu closed 1 year ago

pixeldesu commented 1 year ago

I tried playing around with a project where I worked with this fork and managed to get the findings shown.

I left it as two different outputs because it advertises github-pr-review to include the link to the errored/warned rules, in every other check type the link is not included.

To simplify things we could consider just dropping the condition for reporter type and always use the same output.

Example (filtered findings indicates errors have been found, before it was 0 always):

Link of run with forked action: https://github.com/Retrospring/retrospring/runs/10737844150

screenshot

Fixes #85

github-actions[bot] commented 1 year ago

🚀 [bumpr] Bumped! New version:v1.15.0 Changes:v1.14.0...v1.15.0

review-dog commented 1 year ago

Hi, @pixeldesu! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!