Closed jhulndev closed 3 years ago
Hey @jason-huling !
Apologies for getting back to you so late, I had no time to allocate to this 😞 But I am back now! 🎉
Hm... this is indeed an weird one. I assume it's still valid? If that is the case, can you please re-create a PR on jason-huling/action-tflint so we can check it out together? GitHub Actions cleaned up the history on that repo and I can't see any actions.
Closing due to timeout. Feel free to re-open if it's still relevant!
I've done a little more research into this issue and think that there is either an issue with tflint's output and the reviewdog filter_mode, or I have a misunderstanding of how filter_mode is supposed to behave 😄 .
For troubleshooting I have forked and modified setup.sh here: https://github.com/jason-huling/action-tflint/blob/flag-bugfix/script.sh
I ended up creating some other errors at different tflint severities in the same file and even the same
variable
. At a high level I noticed that myflags: "--config=.tflint.hcl"
was getting picked up correctly, but only thewarnings
from tflint were being output. I noticed the other issues from tflint were output as "Notices", which translated toinfo
for checkstyle format. Based on this I setlevel: info
but still didn't work.Once I set
filter_mode: nofilter
it worked as expected, but I would expect that the defaultfilter_mode: added
would have worked as well.Below is the GitHub Action output from my forked action:
Original Issue Description