search

reviewdog / action-tflint

Run tflint with reviewdog on pull requests to enforce best practices
MIT License
107 stars 22 forks source link

Fix tflint deprecation #70

Closed c0nn0rstevens closed 1 year ago

c0nn0rstevens commented 1 year ago

This PR aims to fix the use of deprecated tflint cli syntax which was causing our CI pipeline to fail when using this action. Screenshot 2023-05-16 at 15 38 24

Sebelino commented 1 year ago

Looks like the check fails because of this line: https://github.com/reviewdog/action-tflint/blob/3bbbd23f5a8216ed2a979e7c3f60a7c74a58e161/.github/workflows/tests.yml#L227

The -chdir parameter was not present in that old version of tflint. You can fix the error by setting this value to 0.46.1. Or remove the line entirely.

c0nn0rstevens commented 1 year ago

Thanks for the pointer! Will add it and push the change. Removing it would default to 'latest', right?

Sebelino commented 1 year ago

Looks that way: https://github.com/reviewdog/action-tflint/blob/3bbbd23f5a8216ed2a979e7c3f60a7c74a58e161/action.yml#L37

review-dog commented 1 year ago

Hi, @c0nn0rstevens! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!