reviewdog / errorformat

Vim's quickfix errorformat implementation in Go
https://reviewdog.github.io/errorformat-playground/
MIT License
109 stars 43 forks source link

add protolint support #117

Closed arahatashun closed 2 years ago

arahatashun commented 2 years ago

What

add protolint support

QA

add protolint.ok and protolint.out run go generate ./...

go test ./... fails at 'cmd/errorformat', but I am not sure this failure is due to my change, because tests of fmts pass

ok      github.com/reviewdog/errorformat        (cached)
FAIL    github.com/reviewdog/errorformat/cmd/errorformat [build failed]
ok      github.com/reviewdog/errorformat/fmts   0.282s
ok      github.com/reviewdog/errorformat/writer (cached)
FAIL
diohabara commented 2 years ago

This test works in my env, so the failure may be dependent on your env.

my env

❯ go version
go version go1.17.7 darwin/amd64

test

❯ gh pr checkout arahatashun:arahata/protolint
remote: Enumerating objects: 12, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 8 (delta 5), reused 8 (delta 5), pack-reused 0
Unpacking objects: 100% (8/8), 1.01 KiB | 129.00 KiB/s, done.
From ssh://github.com/reviewdog/errorformat
 * [new ref]         refs/pull/117/head -> arahata/protolint
Switched to branch 'arahata/protolint'

❯ go generate ./...
go: downloading github.com/haya14busa/go-checkstyle v0.0.0-20170303121022-5e9d09f51fa1
go: downloading github.com/haya14busa/go-sarif v0.0.0-20210102043135-e2c5fed2fa3d

❯ go test ./...
ok      github.com/reviewdog/errorformat    0.629s
ok      github.com/reviewdog/errorformat/cmd/errorformat    0.806s
ok      github.com/reviewdog/errorformat/fmts   0.410s
ok      github.com/reviewdog/errorformat/writer 0.412s
review-dog commented 2 years ago

Hi, @arahatashun! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!