Closed dmundra closed 3 months ago
We recently noticed that reviewdog was no longer capturing output from remark-lint, here is a comparison:
I tracked down the issue and it is because the output of remark lint was adjusted last year in https://github.com/vfile/vfile-reporter/commit/f987b52afc431c995cfe2ea40fe1b87bc4d1dd47 (and you can see the changes in the documentation here https://github.com/remarkjs/remark/commit/6a43da81f5e123b3abe98f7d4e8946d755a7c2e6#diff-1152eab75d1ca2f7af44b54d8655b0cc01168ea48f5f9de4b346acc526eefb28L155-L160). Most of the whitespace changes is not a big deal but removing the two spaces between warning (or error) and the message causes a failure to match the format. Here is an example of the just that change:
resources/markdown/README.md - 25:3 warning Incorrect list-item indent: add 2 spaces list-item-indent remark-lint + 25:3 warning Incorrect list-item indent: add 2 spaces list-item-indent remark-lint
I believe the format in https://github.com/reviewdog/errorformat/blob/master/fmts/markdown.go#L10-L11 needs to drop the extra space to match the changes. I will try to share a pull request to make that change.
We recently noticed that reviewdog was no longer capturing output from remark-lint, here is a comparison:
I tracked down the issue and it is because the output of remark lint was adjusted last year in https://github.com/vfile/vfile-reporter/commit/f987b52afc431c995cfe2ea40fe1b87bc4d1dd47 (and you can see the changes in the documentation here https://github.com/remarkjs/remark/commit/6a43da81f5e123b3abe98f7d4e8946d755a7c2e6#diff-1152eab75d1ca2f7af44b54d8655b0cc01168ea48f5f9de4b346acc526eefb28L155-L160). Most of the whitespace changes is not a big deal but removing the two spaces between warning (or error) and the message causes a failure to match the format. Here is an example of the just that change:
I believe the format in https://github.com/reviewdog/errorformat/blob/master/fmts/markdown.go#L10-L11 needs to drop the extra space to match the changes. I will try to share a pull request to make that change.