search

reviewdog / errorformat

Vim's quickfix errorformat implementation in Go
https://reviewdog.github.io/errorformat-playground/
MIT License
109 stars 43 forks source link

Add support for gometalinter #20

Closed derekperkins closed 5 years ago

derekperkins commented 7 years ago

https://github.com/alecthomas/gometalinter already normalizes the output for most Go static check tools, so the hard work is mostly done. I would also hope that the output ([govet] below) would show the subtool used rather than always [gometalinter], but that's a minor point.

image

derekperkins commented 7 years ago

cc @alecthomas

alecthomas commented 7 years ago

gometalinter supports formatting output via text/template... It seems like it might be simpler to just format output for vim directly

Sorry, I didn't quite understand the purpose of this tool before. I see that it's a generic implementation of vim's errorformat parser. Pretty cool!

derekperkins commented 7 years ago

@alecthomas I've been implementing https://github.com/haya14busa/reviewdog on our projects today and it's pretty great. Normally if a build fails, you have to dig through the Travis logs to see what happened, but this takes the output and creates a legit GitHub review on the actual lines that are throwing the errors. I've got it running on go vet and golint already, and I'd love to be able to pipe in any of the gometalinter tools.

haya14busa commented 7 years ago

btw, gometalinter seems to support checkstyle xml format https://github.com/alecthomas/gometalinter#checkstyle-xml-format .

So actually we don't need to implement errorformat for gometalinter to use reviewdog. reviewdog supports checkstyle xml format too.

but it might be useful for other cases to add errorformat, so I can include #21.

Thanks