search

reviewdog / reviewdog

🐶 Automated code review tool integrated with any code analysis tools regardless of programming language
https://medium.com/@haya14busa/reviewdog-a-code-review-dog-who-keeps-your-codebase-healthy-d957c471938b#.8xctbaw5u
MIT License
7.82k stars 414 forks source link

Flakehell with reviewdog #1093

Open sailingpalmtree opened 2 years ago

sailingpalmtree commented 2 years ago

Hello,

So I was in need of a GitHub Action that would run static analysis for Python, would let me configure the tools at a high level of detail, would allow me to work with a legacy codebase (ie the ability to ignore warnings on pre-existing code and only show findings on new changes) and finally, add annotated comments to the code on the GH UI.

I didn't find anything that would achieve all of this so I put together my own, using the awesome action-template you provided (thank you!). It's now using the flakehell action to do the Python analysis on the legacy codebase and uses reviewdog to report the findings inline on the code.

Link to my repo: https://github.com/sailingpalmtree/reviewdog-flakehell-action It's also on the Marketplace.

I did invest a bunch of time to test everything but I'm sure there's more that could be done. All the testing I did is recorded in my README.

If you'd like I can make a PR to add the plugin to your repo, and I'll be happy to maintain it there going forward. It can stay in my repo too, whichever you prefer.

Thanks for the great reviewdog set of tools!

haya14busa commented 2 years ago

Hi @sailingpalmtree,

Thank you for creating the action! I invited you to the reviewdog org. Please feel free to move the repo or maintain the repo on your own.