ActiveRecord routines set columns to empty string if they have no value in the data array.

[soapdog]

Summary

When using the ActiveRecord implementation, if the developer passes an array with empty elements, RevIgniter sets them to empty strings when saving/updating. So if a developer fetches a record with some null columns, they are coerced into empty by LC, then saves the record, those NULL values are overwritten with empty which is not the same value.

Expected result: [What you expect to happen]

Set them to null or ignore them.

Observed result: [What actually happens]

Values are set to empty string.

Recipe to Reproduce

• Create a table with many columns.
• Create a record with some of those columns as null values, use a datetime column for that.
• Fetch the record,
• Change some columns.
• Save the record.
• Those null fields will become empty fields. In the case of the date, it will be set to 0000-00-00 which is not a valid date.

Versions

Latest

Additional Information

This causes MySQL 5.7 to abort transactions. So users who are happily developing with RevIgniter and upgrade their database server might start seeing their database break and their system unstable before realizing what is happening.

I think the best practice would be for the ActiveRecord implementation to ignore columns with empty values, as in, not add them to either update or insert.

[revig]

@soapdog I modified function rigDbValuesSet() in DBactiveRec.livecodescript according to your report. Could you please replace your library with the new one and check if everything works as expected?