revig / revigniter

Framework for people who build websites using LiveCode
https://revigniter.com/
Apache License 2.0
28 stars 9 forks source link

User Guide UI enhancements #5

Closed bhall2001 closed 8 years ago

bhall2001 commented 8 years ago

Added custom.css to all .html files. Added custom css to increase font size to a more modern size as spec’d by numerous HIGs including Apple and Google for minimum font size for reading on a web page. I actually went with a smaller size than is recommended but I find the size is very readable and much easier than original font sizing. Also added fix for the “Table of Contents” tab with the new larger graphic to prevent odd word wrapping of text in tab.

revig commented 8 years ago

As your modifications unintentionally change the height of the breadcrumb container and the width of the form in the "navbar" I'd like to suggest 2 additions to your custom styles:

body {
    font-size: 14px;
}
form.navbar-form.navbar-right {
    font-size: 12px;
}
#close-button, #open-button {
    margin-bottom: -18px;
}
.slide-button {
    width: 180px;
    height: 18px;
}
pre code {
    font-size: 13px;
}

To avoid the need to load an additional CSS file (custom.css) I'd prefer to embed the modifications in the main stylesheet bootstrap.min.css. To incorporate your styles you need to change 2 files (style.less and bootstrap-overwrites.less) and compile bootstrap.less. The output file is bootstrap.min.css.

To change the body font-size set @fontSizeBase in style.less.

You find form.navbar-form.navbar-right in bootstrap-overwrites.less. There you can add a 12px font-size.

margin-bottom for #close-button, #open-button is in style.less.

You find .slide-button in style.less too.

For pre code you need to add a variable like @fontSizeCode to style.less and then change @fontSizeBase to @fontSizeCode in bootstrap-overwrites.less.

Regarding the missing jquery.min.map file: Actually the server response is not 404, the 404 error is only shown in developer tools of browsers which support .map files. So, as this file is only requested while using developer tools I'd rather remove the line:

//@ sourceMappingURL=jquery.min.map

in jQuery-1.9.1.min.js than add the jquery.min.map because I don't think we ever need to mess with jQuery.

bhall2001 commented 8 years ago

Cool. I was trying to do things off to the side. I'll incorporate the changes into .less and remove the .map file. Now I need some Git-Help.... Should I close this pull request out? I've never done that before so before I screw something up let me know if that is the correct way to proceed.

bhall2001 commented 8 years ago

I've closed this pull request based on the feedback.