revig / revigniter

Framework for people who build websites using LiveCode
https://revigniter.com/
Apache License 2.0
28 stars 9 forks source link

Fixed missing else #9

Closed bhall2001 closed 7 years ago

bhall2001 commented 7 years ago

In order to handle default routes where revigniter is not at the root of the a web structure, an else needs to be added to correctly set the default controller. This appears to be a regression bug introduced when modules were added.

revig commented 7 years ago

Thanks for the pull request, but I can not reproduce your findings regarding routing of nested revIgniter installations. In my test I set up revIgniter in an environment like yours (LC server 8.1.5, Mac OS 10.12.5, revIgniter 1.9.6), all worked as expected. Then I installed LC server 8.1.5 and revIgniter 1.9.6 on On-Rev so that you can check it out yourself. The URL is https://ritest.rabit.on-rev.com/. revIgniter is installed in a subdirectory called “nested”. So the URL to revIgniter is https://ritest.rabit.on-rev.com/nested/. You can try: https://ritest.rabit.on-rev.com/nested/index.lc/welcome, https://ritest.rabit.on-rev.com/nested/index.lc and https://ritest.rabit.on-rev.com/nested/. All works as expected and of course, there is no mod_rewrite thingy in the .htacces file. The value of gConfig["baseUrl"] is “https://ritest.rabit.on-rev.com/nested/”.

bhall2001 commented 7 years ago

I'm going to chalk it up to a configuration issue on my side then. Sorry for the trouble, Bob