Update clean-css to latest version

revivek / oy

Render HTML emails on the server with React.

MIT License

834 stars 47 forks source link

Update clean-css to latest version #70

Closed weaintplastic closed 7 years ago

weaintplastic commented 7 years ago

I've updated the clean-css dependency to version 4.* since it is using a newer version of source-map which is compatible with webpack 2. Currently oy is not working with webpack 2 due to some dynamic requires in source-map.

Update package.json dependecy
Update Render.js since minify() of version 4 can't handle undefined
Remove CSS unsafe check for closing style tag since clean-css takes care of it in the new version. It returns empty styles plus a warning in the result of minify.
Remove tests for closing style tag

weaintplastic commented 7 years ago

Hi, do you have any thoughts on this change?

weaintplastic commented 7 years ago

@revivek Do you have any thoughts on this? Would love to hear your feedback.

revivek commented 7 years ago

Sorry for the delay—I've been traveling for the last 3 weeks and just got back. Will try to review this weekend.

weaintplastic commented 7 years ago

Thanks a lot @revivek

revivek commented 7 years ago

Thanks, this looks good to me! Interesting that webpack is a use-case here. I've only ever used webpack for bundling assets, though I suppose there's nothing holding it back from being used for backends too. Once you resolve the conflicts, I'll merge.

weaintplastic commented 7 years ago

@revivek Thanks a lot for reviewing. Addressed the conflicts and should be good to go now.

And yes, webpack is a pretty strange use-case here. But keeping the dependency tree up to date is a good idea anyways I guess?

revivek commented 7 years ago

Word.