search

revivek / oy

Render HTML emails on the server with React.
MIT License
834 stars 47 forks source link

Added preliminary typescript definitions #82

Closed sampsonjoliver closed 6 years ago

sampsonjoliver commented 6 years ago

Preliminary effort at adding typescript typings.

These aren't entirely complete, as any comparison against the tests file will reveal, but it covers most of the documented usage of the module, so should be effective enough for 90% of users.

Happy to take commits for changes and additional types before approving and merging.

sampsonjoliver commented 6 years ago

Pushed some changes, including some of @revivek's feedback, and added some more type completeness :)

See commit 67223ad24ebb3b6f609bc4c04719b56d3f6c0047

sampsonjoliver commented 6 years ago

Moved declarations file to project root =)

Discussion on top-level declare of Oy namespace ongoing

sampsonjoliver commented 6 years ago

Answered, and squashed. Thanks for the help

I don't have write access, so I'll leave to you to merge.

revivek commented 6 years ago

Thanks! I'll do a minor update this weekend that should include this.