Upgrade to React 17 - Githubissues

mtjoe3 commented 3 years ago

Summary

Add react@^17.0.0 and react-dom@^17.0.0 as a peer dependency of oy
Upgrade to use react@^17.0.0 and react-dom@^17.0.0 in dev dependency
Update a failing test - there is a change in React 17 to make error messages more explicit, this broke a test in Oy-test.js
Looking at the breaking changes in React 17, it does not seem like any of those would impact Oy

I've tested this against my codebase, which is currently using Oy to render email templates

revivek commented 3 years ago

Thank you!

agrajak commented 2 years ago

hello @revivek, is there any publish plan for this MR?

It seems like current lastest published version on npm (0.11.2) doesn't contain this MR.

revivek commented 2 years ago

Hi @agrajak, thanks for bumping. I just published 0.12.0 to npm with these changes. Let me know if you have any issues.