search

revk / ESP32-Faikin

ESP32 based module to control Daikin aircon units
GNU General Public License v3.0
319 stars 45 forks source link

[BUG] "on/off" icon isn't displayed correctly by a web browser #322

Closed Sonic-Amiga closed 1 month ago

Sonic-Amiga commented 1 month ago

I see you've switched from text to icons again; I understand that it should be a standard on/off symbol, but at least on Windows browsers can't render it: image And that's not Firefox-specific issue; i tried Edge; it also looks like a square

Sonic-Amiga commented 1 month ago

Tested on Firefox and Chrome for Android; the same thing

revk commented 1 month ago

There is a setting now. Have a look.

Sonic-Amiga commented 1 month ago

You mean "noicons" setting ? I know, but it looks boring without all the icons.

revk commented 1 month ago

You want some of the icons but not all!!!

Isn't Unicode fun.

Sonic-Amiga commented 1 month ago

Yes. And i'd say showing text instead of this particular icon should be the default; because i suggest there are plenty of users with not-so-cutting-edge systems around; who will see the empty square. It definitely feels like a bug, even to me, who knows the drill.

I replaced icon back with text in my port; but yours is subject too; plus it's yet another unwanted diff. I'd like to be as upstream as possible, this simplifies things a lot. I even have a dream of complete merge; but currently amount of #ifdef's would still be rather large; you wouldn't be happy with such a merge, neither it would be easy to maintain.

revk commented 1 month ago

The code needs refactoring to segregate the protocols anyway, and the comms. It started a one protocol and grew.