revo-market / revo-interface

An open source interface for the Revo protocol
https://revo.market/
GNU General Public License v3.0
2 stars 3 forks source link

Support only WC v1 #14

Open kathaypacific opened 2 years ago

kathaypacific commented 2 years ago

Ubeswap desktop uses WC v2 which doesn't work with Valora, we should probably update to only use WC v1

AC

cajubelt commented 2 years ago

this may have been implemented in Ubeswap after we forked, probly worth checking that

kathaypacific commented 2 years ago

hum, am i missing something? i've never been able to connect Valora to Ubeswap desktop before. every time i scan the QR, i see this error message in the app.

Image from iOS (2)

i've checked with Jean before and it seems like this behaviour is because Ube is still using use-contractkit v1. https://github.com/Ubeswap/ubeswap-interface/blob/807e07967f5c3da2012eacddaa873a90eb5883f4/package.json#L117 there is v2 available now, which might/should fix the issue.

cajubelt commented 2 years ago

@kathaypacific that sounds right, and yes the issue also exists on Ubeswap. I think this is a bit lower priority than a couple other issues though, especially:

32

33

aaronmgdr commented 1 year ago

Recommend upgrading to from use-contract-kit to @celo/react-celo@5.0 (out this week with wc v2 support)

WCv1 will stop working march 1st