add zap out - Githubissues

revo-market / revo-interface

An open source interface for the Revo protocol

https://revo.market/

GNU General Public License v3.0

2 stars 3 forks source link

add zap out #25

Closed kathaypacific closed 2 years ago

kathaypacific commented 2 years ago

TODO:

show error states (use the "swapInputError" variable to display an error and disable the buttons)
we should refresh the card once a user has zapped in/zapped out - i couldn't get this data to refresh, as we need to trigger a refresh of useCompoundRegistry. i think the easiest way to do this is to make useCompoundRegistry listen to a redux variable and re-call the contract after a user action

kathaypacific commented 2 years ago

@lisaqyli i fixed the bug that we saw with the zap out amount looking weird :) so i think zap in and out should be working correctly now.

just had a thought on the button states, maybe these 2 button states can be reversed? i was in the zap out view but the zap out button became greyed out which i guess makes sense as it's disabled, but also kind of looks like the entire "zap out" functionality is disabled - maybe we should have a highlighted look instead of a disabled look?