search

revoframework / Revo

Event Sourcing, CQRS and DDD framework for C#/.NET Core.
https://docs.revoframework.net/
MIT License
644 stars 70 forks source link

Bugfix: external events enqueued twice #36

Closed martinzima closed 3 years ago

martinzima commented 3 years ago

-fixed: async events might occasionally have gotten enqueued twice during EF Core's coordinated transaction -improved: better performance when enqueueing async events & for EFCoreCrudRepository.IsAttached -fixed: ExternalEventSourceCatchUp should dispatch messages with metadata mapped from the event record (e.g. ID)

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (cc17171) into develop (2b7830c) will increase coverage by 0.09%. The diff coverage is 50.00%.

:exclamation: Current head cc17171 differs from pull request most recent head 64f2a1d. Consider uploading reports for the commit 64f2a1d to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage    36.62%   36.72%   +0.09%     
===========================================
  Files          475      475              
  Lines         7011     7012       +1     
===========================================
+ Hits          2568     2575       +7     
+ Misses        4443     4437       -6
Impacted Files Coverage Δ
...EFCore/DataAccess/Entities/EFCoreCrudRepository.cs 0.00% <0.00%> (ø)
...FCore/DataAccess/Entities/RequestDbContextCache.cs 0.00% <ø> (ø)
...evo.EFCore/EventStores/EFCoreExternalEventStore.cs 0.00% <0.00%> (ø)
...Revo.EFCore/Events/EFCoreAsyncEventQueueManager.cs 0.00% <0.00%> (ø)
...FCore/Projections/EFCoreProjectionEventListener.cs 0.00% <ø> (ø)
...FCore/Repositories/EFCoreCoordinatedTransaction.cs 0.00% <ø> (ø)
Revo.Core/Core/TaskFactoryExtensions.cs 50.00% <ø> (ø)
.../EventStores/Generic/ExternalEventSourceCatchUp.cs 100.00% <ø> (+100.00%) :arrow_up:
...tructure/EventStores/Generic/ExternalEventStore.cs 0.00% <ø> (ø)
...ucture/Events/Async/Generic/ExternalEventRecord.cs 83.33% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b7830c...64f2a1d. Read the comment docs.