revoframework / Revo

Event Sourcing, CQRS and DDD framework for C#/.NET Core.
https://docs.revoframework.net/
MIT License
644 stars 70 forks source link

Remove NLog dependency & replace with Microsoft.Extensions.Logging #63

Closed martinzima closed 1 year ago

martinzima commented 1 year ago

removed NLog dependency, replaced with standard Microsoft.Extensions.Logging; if you want to keep using NLog, you have to install it in your projects and set-up the adapters on your own

codecov[bot] commented 1 year ago

Codecov Report

Merging #63 (a0472aa) into develop (300caa1) will increase coverage by 0.03%. The diff coverage is 35.08%.

:exclamation: Current head a0472aa differs from pull request most recent head 2554796. Consider uploading reports for the commit 2554796 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #63      +/-   ##
===========================================
+ Coverage    36.99%   37.03%   +0.03%     
===========================================
  Files          472      473       +1     
  Lines         6565     6577      +12     
===========================================
+ Hits          2429     2436       +7     
- Misses        4136     4141       +5     
Impacted Files Coverage Δ
...History/ChangeTracking/HistoryAutoMapperProfile.cs 100.00% <ø> (ø)
.../Channels/Buffering/BufferedNotificationStartup.cs 0.00% <ø> (ø)
...cations/Channels/Buffering/NotificationPipeline.cs 100.00% <ø> (ø)
...ations/Channels/Mail/SmtpMailNotificationSender.cs 0.00% <ø> (ø)
...ers/AspNetCore/Revo.AspNetCore/AspNetCoreModule.cs 0.00% <ø> (ø)
...NetCore/Revo.AspNetCore/AspNetCoreMvcExtensions.cs 0.00% <ø> (ø)
...tCore/Revo.AspNetCore/Core/HangfireJobActivator.cs 0.00% <ø> (ø)
...evo.AspNetCore/Core/HangfireStartupConfigurator.cs 0.00% <ø> (ø)
...roviders/AspNetCore/Revo.AspNetCore/RevoStartup.cs 0.00% <0.00%> (ø)
...DataAccess/EF6DataAccessConfigurationExtensions.cs 0.00% <ø> (ø)
... and 82 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 300caa1...2554796. Read the comment docs.