revolist / revogrid

Powerful virtual data grid smartsheet with advanced customization. Best features from excel plus incredible performance 🔋
https://rv-grid.com
MIT License
2.74k stars 171 forks source link

Adapter function issue in React 18: ReactDOM.render is no longer supported and _client.unmountComponentAtNode is not function #392

Closed Mike-Coder-20 closed 1 year ago

Mike-Coder-20 commented 1 year ago

After changing to React 18, the following error is found that:

However, these functions are used in the adapter function (https://revolist.github.io/revogrid/guide/framework.react.component.html ) Any workaround can be applied in the adapter function for React 18?

To reproduce the issue

Environment revolist/revogrid-react : 1.9.0 React version : 18.2.0 react-dom version : 18.2.0 please visit: https://codesandbox.io/s/revogrid-react-component-forked-clou1y?file=/src/App.js

m2a2x commented 1 year ago

Updated in react branch, it's still recommended to avoid usage of react component inside of the cell for the performance reasons and use VNode provided by stenciljs. Sample provided in react repo.