fix: app closure for macOS users in window close event

revoltchat / desktop

Revolt Desktop App

GNU Affero General Public License v3.0

753 stars 88 forks source link

fix: app closure for macOS users in window close event #160

Open 1yizhuo1 opened 1 year ago

1yizhuo1 commented 1 year ago

Please make sure to check the following tasks before opening and submitting a PR

[x] I understand and have followed the contribution guide
[x] I have tested my changes locally and they are working as intended
[x] These changes do not have any notable side effects on other Revolt projects

this pr allows the application to close instantly when the "Quit" option is selected in the dock on Revolt (the application will now close immediately upon clicking "quit")

insertish commented 2 months ago

Will validate behaviour before merge, either need someone else with a Mac to confirm behaviour, screencast to be included with PR, or I will personally test it in 1.5 weeks when I'm back home.

insertish commented 1 month ago

The current behaviour appears to already be correct?

https://github.com/user-attachments/assets/1d3ef445-282a-42e2-8d82-a02ab82520a6

I'm currently on macOS 15 Beta 1, does this behave differently on other versions?