feat: include replies in copied text

revoltchat / frontend

Monorepo for Revolt's frontend.

https://revolt.chat

GNU Affero General Public License v3.0

210 stars 62 forks source link

feat: include replies in copied text #285

Closed JackDotJS closed 1 month ago

JackDotJS commented 5 months ago

Please make sure to check the following tasks before opening and submitting a PR

[x] I understand and have followed the contribution guide
[x] I have tested my changes locally and they are working as intended

this PR will resolve #172

currently a draft while i sort out some edge cases and locale stuff, but the basic functionality is there already.

JackDotJS commented 5 months ago

ran into some formatting issues with solid components so i figured i'd put all the logic into its own function instead. i think it ends up being much more readable as a result anyway, but i can revert it if solid components would be preferred.

aside from that, im also wondering if i should just expand to PR to fix copy text in general since there seems to be a number of issues outside of just missing the "replying to" text.

JackDotJS commented 1 month ago

gonna be closing this for now. this is super old, fails some checks, and doesn't comply with new DCO thing.

the changes as-is are pretty minimal though, so i can probably revisit it soon.