revoltchat / translations

i18n translations of Revolt
https://translate.revolt.chat/projects/revolt/web-app/
GNU General Public License v3.0
49 stars 60 forks source link

badge: pt_BR for KitsuShiro #263

Closed YoshiroOno closed 1 year ago

YoshiroOno commented 1 year ago

What language(s) did you translate?

Brazilian Portuguese

What is your Revolt ID?

01H84AH6MMVPJDQ8RGD6YE0SBE

Link to Weblate profile

https://translate.revolt.chat/user/KitsuShiro/

Validations

Rexogamer commented 1 year ago

cc @yanndere

YoshiroOno commented 1 year ago

he does not seem to be actively accessing github, only weblate.

ghost commented 1 year ago

Thanks for contributing to the Brazilian translation. I've analyzed the strings you sent to the Web App component and I approve your badge request.

There are some points which I would like to mention, though:

[!IMPORTANT] Inconsistency: You sent different translations for the same text (same context). This was seen in 8 unique strings, most of them (7) referring to client settings.

If this is (enabled/disabled):

  • Se essa opção estiver
  • Se isso estiver
  • Se isso for

I also found other inconsistencies, but I hope we can discuss those on Revolt.

[!Note] Lack of communication: I removed one of the suggestions you sent and even provided the reason. I also added a translation comment right after. Some hours later you made the same suggestion without providing further details. Although this was a minor issue, communication is very important if we are going to work as a team.

YoshiroOno commented 1 year ago

sure, I'll keep an eye out for these details.

I considered the understandability of the users at the time I was translating, so at some point there was a mismatch, because I didn't check the string in which it was attached.