Closed AlexKurek closed 3 weeks ago
It seems time.perf_counter
was introduced in Python 3.3, so it will not work in genericpipeline pipelines as those only run under Python 2. Perhaps adding a fallback to time.clock
to maintain compatability is useful.
@AlexKurek what python version do you use?
@revoltek For Prefactor I use 2.7.17
The master of losoto is only python 3, I think you need to go back to an older release (1.0)
I was able to run entire Prefactor using second to last commit :)
Fully supporting the move of stuff to Python 3, but I think it is worth noting that this will make losoto unusable in and break prefactor currently, as the genericpipeline does not run under Python 3. This should be fixed once the CWL version is done, but I don't know the status of that.
I think a lot has changed and been added since 1.0 and 2.0 that is currently being used right?
I was able to run entire Prefactor using second to last commit :)
Could this commit perhaps be made a 2.1 or some other intermittent release in that case? That would give a nice reference point from where on it no longer works for Python 2 / prefactor.
Hum, there are a large number of python3 specific parts in losoto since release 2.0, I think not all operations work in python2 nor I can be sure of the results. Actually, I really though python2 was not working at all with the latest master. The easiest is to add a 'try' to just account for this
Ah I didn't realize that. I guess we got extremely lucky the past years then haha.
Using current master when I try to run Prefactor Im getting at calibrator step:
Full log is attached: pipeline-Pre-Facet-Calibrator-2020-07-27T15%3A52%3A27.zip