search

revolunet / angular-carousel

Mobile friendly AngularJS carousel
http://revolunet.github.io/angular-carousel
MIT License
1.55k stars 705 forks source link

HTML data-rn-carousel not working #330

Open nicky-lenaers opened 9 years ago

nicky-lenaers commented 9 years ago

I like valid markup, so I prefix my angular apps with data-. All works well but...

Prefixing the mandatory rn-carousel with data- breaks the carousel. Prefixing optional attributes like rn-carousel-easing or rn-carousel-duration, however, does not. So I can verify that I can safely use data-rn-carousel-easing and data-rn-carousel-duration, but not data-rn-carousel.

Error I got: 10 $digest() iterations reached. Aborting!

Please fix.

slarti-b commented 9 years ago

To add to this (I also want this fixed if possible), If i use rn-carousel rn-carousel-transition="hexagon" it works as epxected. if I use data-rn-carousel rn-carousel-transition="hexagon" or data-rn-carousel data-rn-carousel-transition="hexagon" I get all my slides displayed (no carousel). However, if I use rn-carousel data-rn-carousel-transition="hexagon" then it breaks completely and doesn't show any of the slides. No errors in the console. Using carousel version v0.3.13 with angular v1.3.15