Fix bug with fields support on create method

justinsa commented 9 years ago

Fixes #65 - addProduct now supports custom properties (dimensions and metrics) Additionally:

The call to GA create was being incorrectly formatted if object values were being supplied for both cookieConfig and the options. All of these properties are defined as fields in the GA documentation and can be sent together in one object.
All methods and properties related to cookieConfig have been marked as deprecated and will be removed in a future release.
cookieConfig is also not supported by classic analytics and has been corrected in the implementation and documentation as such.

justinsa commented 9 years ago

Leaving out for public review before merging on Friday night PST.

stramel commented 9 years ago

Looks pretty good from a code standpoint, unable to run through it but build passed so I will give it a :+1:

revolunet / angular-google-analytics