Add support for custom set commands on accounts

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps

MIT License

652 stars 172 forks source link

Add support for custom set commands on accounts #117

Closed justinsa closed 8 years ago

justinsa commented 8 years ago

Fixes #71, #116

Support for custom set commands that are run immediately after account object creation.
Support for a custom select function on each account object that can disable a tracker by returning false.

justinsa commented 8 years ago

Will leave open for a couple of days before merging and publishing. @offsky, this implements the feature you were requesting as a more general solution. Set commands are permitted to be account specific and hence this pushes you to use the account object to customize for your scenario. Please see the README and additional unit test I added for clarification.

justinsa commented 8 years ago

@sonicparke the second part of this PR contains the feature you wanted in #71. Please have a review and provide any feedback you might have. Thanks.

offsky commented 8 years ago

This looks good. It will resolve my issue completely.

justinsa commented 8 years ago

Merging as no response on original commit in 2 days and sign-off received on the second feature addition by @offsky.