search

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 172 forks source link

Added the Analytics.pageView() in docs #123

Closed jasonvdzeeuw closed 8 years ago

jasonvdzeeuw commented 8 years ago

ISSUE #103 All changes/functions will only be pushed to analytics when calling Analytics.pageView() after them. This wasn't in the docs, so people stumbled upon it.

justinsa commented 8 years ago

@jasonvdzeeuw Thanks for taking this up. Adding this over-and-over doesn't assist in making the document more usable though. It would be better to put an IMPORTANT! message near the start explaining this so it doesn't have to be repeated after every single example command. The messaging could be:

IMPORTANT! Due to how Google Analytics works, it is important to remember that you must always call Analytics.pageView(); when you want to push setting changes and function calls to Google Analytics.

justinsa commented 8 years ago

Closing this abandoned pull request as the desired statement is incorporated in the README in another commit/PR.