search

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 179 forks source link

Support for $routeProvider #141

Closed Toxantron closed 8 years ago

Toxantron commented 8 years ago

I forked the project to add support for defining the tracking URL in the $routeProvider config because I needed it in a project. Maybe you can use this as well.

You can see and debug it in production use at Scrumpoker Online.

Toxantron commented 8 years ago

I do apologize for the two commits though. ;)

justinsa commented 8 years ago

This is great functionality, thanks for submitting a PR. I have a couple of suggestions above and this requires some unit tests to go along with it.

Toxantron commented 8 years ago

Hopefully I applied all suggestions as intended. I will check my IDEs settings when I get home - it all looks nice until I commit and see it on github.

I will leave this open and add unit tests to meet requirements.

justinsa commented 8 years ago

Please add some unit tests to exercise this new logic you are introducing. It will help keep the library stable into the future. Thanks!

Toxantron commented 8 years ago

Will do. Will let you know when I'm done.

Toxantron commented 8 years ago

Maybe this PR was a little too soon, let me clean this up and I will create a new one.