search

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 172 forks source link

Support for $routeProvider #142

Closed Toxantron closed 8 years ago

Toxantron commented 8 years ago

This PR adds support for reading tracking URLs from the $route service of the ngRoute model. I also started with the unit tests. Since I am new to karma and JS unit tests (not unit-tests in general) I wanted to leave this open in case someone wants to join in.

If not I expect to finish unit tests till sunday.

If anyone wants to debug or look at it: Non-minified version runs on Scrumpoker Online.

Toxantron commented 8 years ago

So, all finished from my side. Feedback welcome.

Toxantron commented 8 years ago

Done. Anything else?

Toxantron commented 8 years ago

This what you had in mind? Looks much cleaner and should be faster.

Thanks for the feedback. Open Source never fails.

justinsa commented 8 years ago

Those are all of my comments and it will be good to go. Thanks for this change, it is a good one.

Toxantron commented 8 years ago

Will do when I get home.

Toxantron commented 8 years ago

Hope this covers all we talked about.

revolunet commented 8 years ago

Thanks both of you for this addition and the time took to craft this nice PR and tests !

justinsa commented 8 years ago

Great work @Toxantron. Thanks for contributing.

Toxantron commented 8 years ago

It was fun and I learned JS unit tests in the process. ;)