search

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 172 forks source link

PageTracking configuration in $route #144

Closed Toxantron closed 8 years ago

Toxantron commented 8 years ago

This builds upon PR #142 and fixes bug report #76 for applications that use ngRoute. It reduces tracked pages to those routes that do define a templateUrl (routes with a page) and skips routes marked with dontTrack: true property.

I allready included unit tests to verify correct behahior.

Toxantron commented 8 years ago

Hope I covered everything you noted.

justinsa commented 8 years ago

@Toxantron Just 3 spots where the comments don't match the property name and it is ready to merge. Thanks for this. Another nice addition.

Toxantron commented 8 years ago

Alright, totally forgot about the comments. Thank you for taking the time to review it thoroughly.