Separate script injection and tracker setup methods

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps

MIT License

652 stars 172 forks source link

Closed justinsa closed 8 years ago

justinsa commented 8 years ago

Resolves #152

Backwards compatible change to split the create script methods along separation of concern lines.
registerScriptTags replaces both create*ScriptTag methods.
registerTrackers performs all tracker setup.
Added deprecation warnings to all deprecated methods.

justinsa commented 8 years ago

@Toxantron and @Kyoss79 please review this PR when you have a chance as it provides a resolution to issue #152. Thanks.

Toxantron commented 8 years ago

Apart from that one comment I couldn't find anything. You have been busy, this is quite the refactoring.