search

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 172 forks source link

auto page tracking fix #156

Closed theromis closed 8 years ago

Toxantron commented 8 years ago

Correct me if I am wrong, but this is not a fix. It simply alters the module to use ui-router events. If you use that module please just configure Analytics to use the event you want as described in the documentation. But this PR is not a fix but alters the default behaviour of the library.

Toxantron commented 8 years ago

Sample code from documentation:

AnalyticsProvider.setPageEvent('$stateChangeSuccess')
justinsa commented 8 years ago

As @Toxantron points out, this isn't a fix, but a configuration option that is described in the readme.

theromis commented 8 years ago

it was strange for me that code doesn't work by default and requires "tuning" before is starts reporting

justinsa commented 8 years ago

That is because you are using ui-router instead of ng-route. ui-router is not the default implementation of routing in Angular. On May 9, 2016 10:46 AM, Roman Vasilyev notifications@github.com wrote:it was strange for me that code doesn't work by default and requires "tuning" before is starts reporting

—You are receiving this because you modified the open/close state.Reply to this email directly or view it on GitHub