search

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 172 forks source link

Angular 2.0 #160

Open Toxantron opened 8 years ago

Toxantron commented 8 years ago

Since angular 2.0 seems to be around the corner we might want to start developing a version 2.0 of the library on a branch. What do you think?

revolunet commented 8 years ago

Hi, I'm not much into Angular apps anymore so can't help here but maybe @justinsa @adam187 @deltaepsilon ?

Toxantron commented 8 years ago

If they are interested we could create a branch ng-2 and start porting the module. I'd be happy to contribute via PR against the branch.

adam187 commented 8 years ago

I'm also doing react mainly react nowadays :(

Toxantron commented 8 years ago

Hopefully @justinsa is still on board. ;)

Toxantron commented 8 years ago

I created a branch on my fork and will start porting to angular2 there. Anyone interested to join in is welcome. If this repo gets a branch I will open a PR.

justinsa commented 8 years ago

@Toxantron I may or may not get a chance to participate in this over the next two months.

Toxantron commented 8 years ago

Would be nice to have you on board. The way I see it angular2 is still in beta and even after release I assume it will take some time before applications reach production state and require tracking.

And what would I do without your code reviews. ;)

justinsa commented 8 years ago

I am always happy to code review for you, just mention me in a comment on the code review and I will take a gander.

Toxantron commented 8 years ago

Thanks. I think working with a sparing partner always yields better results. As soon as the branch approaches a state of migrating the libraries logic I will let you know.