Change storage location of offline mode from in-memory array to localStroage

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps

MIT License

652 stars 179 forks source link

Change storage location of offline mode from in-memory array to localStroage #211

Open mohitt opened 6 years ago

mohitt commented 6 years ago

Hi,

Can I extend this module, to allow injection of the storage location of offline events. So, that as per the application need developer can inject. By default it would in-memory array only. So, that it stays backward compatible.

Let me know your thoughts.

Regards Mohit Thakral

justinsa commented 6 years ago

Do you want to extend it with localStorage and/or sessionStorage as per HTML5?

If you keep it fully backwards compatible, add an acceptable suite of unit tests, and ensure there is no requirement on another module / package, then absolutely. You just need to submit a PR for the change and I will be happy to code review, provide feedback, and assist you in getting the change in.