search

revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 179 forks source link

$stateChangeSuccess are now deprecated and disabled by default #220

Open hbdbim opened 6 years ago

hbdbim commented 6 years ago

what now!?

https://ui-router.github.io/guide/ng1/migrate-to-1_0#state-change-events

revolunet commented 6 years ago

yep, we need some patch to handle that;

feelitloveit commented 6 years ago

Waiting for this too...

justinsa commented 6 years ago

@revolunet Perhaps it is time we stopped having ui-router (or ng-router) specific behaviors in the library and instead offer how to set it up as part of the documentation (it is pretty trivial stuff to setup). ui-router deprecating a feature should not require this library to update its version.

revolunet commented 6 years ago

Hi ! i cant really say whats good anymore as i dont use angular much..... but yes, if deprecated, we should to that 👍

Rasha-Dj commented 6 years ago

I am using the new version of ui-router (1.0.13 to be exact) and library is still operational. @hbdbim have you experienced / are you experiencing issues or you are only afraid you might do so in near future?

lsioctl commented 6 years ago

Hello !

I had a related problem using ui-router 1.0.15. Nothing was sent to GA when changing page. Digging further, ui-router switched from

$stateChangeSuccess to $transitions.onSuccess

In the meantime I created a small working module inspired from :

https://dev.to/jordanirabor/using-google-analytics-with-angular-930