revolunet / angular-google-analytics

Google Analytics tracking for your AngularJS apps
MIT License
652 stars 172 forks source link

Encapsulated multiple tracker handling #88

Closed justinsa closed 9 years ago

justinsa commented 9 years ago
justinsa commented 9 years ago

@Karpo72 - this PR will make it easy for anyone to add support for multiple trackers to the individual command functions. The only requirement is adding tests to cover new scenarios where multiple trackers are supported. I have updated existing functions (namely _trackPageView and _trackEvent) that were using the previous copy-paste method to use the _gaMultipleTracker method instead.

justinsa commented 9 years ago

@revolunet - tests are 100% passing.

Karpo72 commented 9 years ago

Ok looks nice...

Karpo72 commented 9 years ago

When is the next version update planed?

revolunet commented 9 years ago

awesome thanks @justinsa ! will be released shortly

revolunet commented 9 years ago

released as 1.0.0 on npm. we should now follow semver