search

revolunet / node-sellsy

Node Sellsy API wrapper
https://github.com/revolunet/node-sellsy
MIT License
17 stars 7 forks source link

Conf upgrade + remove console.log #11

Closed Yarflam closed 3 years ago

Yarflam commented 3 years ago

To correct errors of my issue: https://github.com/revolunet/node-sellsy/issues/10

Thanks ;)

Yarflam commented 3 years ago

Can no one verify and merge? Thank you

elieteyssedou commented 3 years ago

+1 for removing the console.log

@revolunet please, can you check this MR ? 🙏🏻 Thanks a lot :)

Yarflam commented 3 years ago

(the reason for my force-push: I corrected my pseudo/email)

I see 4 collaborators in this repository, @revolunet @nfroidure @risseraka @yereby ; I don't want to create another NPM package for this. I'll add my GIT repository for now. Thank you :D

revolunet commented 3 years ago

Hi, sorry for the delay, i'll take a look in the next week, thanks for helping here

revolunet commented 3 years ago

Hi, i made some more changes in #12, had some issues with eslint, can you please check if ok for you ?

Thanks

Yarflam commented 3 years ago

Hi, thanks for reviewing the code! No problem with your eslint setting.

Just a few warnings detected, nothing more:

/src/Documents.js
   51:15  warning  'e' is defined but never used  no-unused-vars
   71:15  warning  'e' is defined but never used  no-unused-vars
   88:15  warning  'e' is defined but never used  no-unused-vars
  114:15  warning  'e' is defined but never used  no-unused-vars

It's good you deleted the /dist directory, I didn't dare to correct it so as not to disturb your deployment procedures.

revolunet commented 3 years ago

merged in #12 and released in 1.5.4 , thanks @Yarflam