revolunet / sublimetext-markdown-preview

markdown preview and build plugin for sublime text 2/3
MIT License
2.31k stars 362 forks source link

A long list of github emojis are not supported with githubemoji extension #222

Closed aziz closed 10 years ago

aziz commented 10 years ago

I was playing with the new features added to this plugin that I realised a long list of github emoji codes are not supported. here is the list of those that are NOT supported:

:-1:
:1234:
:aerial_tramway:
:airplane:
:arrow_double_down:
:arrow_heading_up:
:arrow_left:
:arrow_right:
:arrows_counterclockwise:
:athletic_shoe:
:back:
:baggage_claim:
:balloon:
:bamboo:
:bank:
:battery:
:bear:
:bee:
:black_circle:
:black_joker:
:black_large_square:
:black_medium_small_square:
:black_medium_square:
:black_small_square:
:blue_book:
:bowling:
:bowtie:
:bridge_at_night:
:bullettrain_side:
:bus:
:busts_in_silhouette:
:camel:
:cancer:
:candy:
:chart_with_downwards_trend:
:checkered_flag:
:christmas_tree:
:clock10:
:clock3:
:clock730:
:construction:
:cool:
:cop:
:corn:
:couple_with_heart:
:crescent_moon:
:de:
:department_store:
:diamond_shape_with_a_dot_inside:
:dizzy_face:
:do_not_litter:
:earth_asia:
:email:
:envelope:
:envelope_with_arrow:
:file_folder:
:finnadie:
:fire_engine:
:first_quarter_moon:
:first_quarter_moon_with_face:
:flipper:
:football:
:footprints:
:fork_and_knife:
:four_leaf_clover:
:full_moon_with_face:
:grapes:
:grey_exclamation:
:guitar:
:handbag:
:hatching_chick:
:hear_no_evil:
:heart:
:heart_eyes:
:heavy_multiplication_x:
:herb:
:hourglass:
:house:
:icecream:
:ideograph_advantage:
:information_desk_person:
:innocent:
:japanese_castle:
:key:
:kiss:
:kissing_cat:
:lantern:
:large_orange_diamond:
:last_quarter_moon:
:ledger:
:left_right_arrow:
:leopard:
:link:
:loop:
:loud_sound:
:mailbox_with_no_mail:
:man:
:man_with_gua_pi_mao:
:memo:
:mens:
:metal:
:mount_fuji:
:movie_camera:
:musical_score:
:night_with_stars:
:no_entry:
:notes:
:ocean:
:ok:
:oncoming_automobile:
:one:
:open_book:
:open_mouth:
:ophiuchus:
:package:
:page_facing_up:
:pager:
:pencil2:
:pensive:
:performing_arts:
:persevere:
:person_with_pouting_face:
:pig2:
:point_right:
:pound:
:pouting_cat:
:rage4:
:raised_hand:
:ram:
:registered:
:relieved:
:ribbon:
:rice_cracker:
:roller_coaster:
:sake:
:secret:
:seedling:
:shipit:
:small_red_triangle_down:
:snail:
:spaghetti:
:sparkle:
:sparkler:
:squirrel:
:star:
:stuck_out_tongue:
:stuck_out_tongue_closed_eyes:
:sunny:
:sweet_potato:
:swimmer:
:ticket:
:tired_face:
:toilet:
:trollface:
:two_hearts:
:two_women_holding_hands:
:u6307:
:unamused:
:us:
:vibration_mode:
:white_flower:
:white_large_square:
:white_medium_small_square:
:white_medium_square:
:white_small_square:
:womans_clothes:
facelessuser commented 10 years ago

Where did you get the list from? I remember find a list on a site, and I just used their list. I honestly didn't spend the time to come up with a fool proof way to get all of the emoji.

aziz commented 10 years ago

To be honest, I don't remember where I get the list. I have a file on my machine with the list of all emoji codes. I've put it up here as a gist

here is the official github repo for emojis

I tested my list with github api and all of them are valid.

facelessuser commented 10 years ago

Cool. I already found the issue for most of them; I wasn't stripping newlines out of the regex. I think the others I am just missing.

facelessuser commented 10 years ago

This has been fixed in https://github.com/revolunet/sublimetext-markdown-preview/pull/223. I now generate a test page when I generate my regex for the script. I verified them in github and in the extension. All of the emoji in your list should be supported. I will tag this later today.

facelessuser commented 10 years ago

This should be in the new tag. Thanks for reporting this.