search

revpoint / logstash-codec-avro_schema_registry

A logstash codec plugin for decoding and encoding Avro records
Other
26 stars 23 forks source link

Fix TLS settings ignore when client_certificate is nil #29

Closed fbaligand closed 9 months ago

fbaligand commented 1 year ago

Currently, when using a TLS connection to avro schema registry with only a server certificate (no client certificate), all TLS settings (client_key, ca_certificate and verify_mode) are ignored because client_certificate setting is nil: https://github.com/revpoint/logstash-codec-avro_schema_registry/blob/master/lib/logstash/codecs/avro_schema_registry.rb#L143

So this PR aims to fix that, doing no check at all, because all required checks are already done by "schema_registry" library itself here: https://github.com/wvanbergen/schema_registry/blob/master/lib/schema_registry/client.rb#L84

fbaligand commented 11 months ago

@revpoint could you review my PR? This is a simple change, but necessary for registries using https without client certificate.

fbaligand commented 9 months ago

Thanks @ryananguiano for the merge!

fbaligand commented 8 months ago

Hi @ryananguiano,

Now that this PR is merged, could you do a new release on RubyGems.org? For example, version 1.2.1.

This would be very useful so that users (like me) can update the plugin in their Logstash installation!

Thanks in advance, Fabien

fbaligand commented 5 months ago

Hi @ryananguiano,

I follow up on this PR. Could you release the plugin onto rubygems.org?

This is really important to be able to install the plugin using Logstash CLI: logstash-plugin install logstash-codec-avro_schema_registry